Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: APNs certificate expired error #314

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

chris13524
Copy link
Member

@chris13524 chris13524 commented Mar 25, 2024

Description

Slack conversation

Captures the client-side certificate expiration error and suspends the tenant when this happens. Also updates the capitalization on the server/client error logging to be consistent with other services.

Resolves #308

How Has This Been Tested?

Not tested

Due Diligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

@chris13524 chris13524 self-assigned this Mar 25, 2024
@arein arein added the accepted The issue has been accepted into the project label Mar 25, 2024
Copy link
Contributor

@geekbrother geekbrother left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@chris13524 chris13524 merged commit d5347fa into main Mar 25, 2024
10 checks passed
@chris13524 chris13524 deleted the fix/apns-certificate-expired branch March 25, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted The issue has been accepted into the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Handling expired APNS certificates properly
3 participants